Skip to content

Commit

Permalink
Allow artificial destinations as span name if neither destination nam…
Browse files Browse the repository at this point in the history
…e nor conversation ID are suitable
  • Loading branch information
arminru committed Jul 10, 2020
1 parent 7bb6131 commit d742494
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ New:

Updates:

- Adapt messaging semantic conventions to include the operation in the span name ([#690](https://github.com/open-telemetry/opentelemetry-specification/pull/690))
- Adapt semantic conventions for the span name of messaging systems ([#690](https://github.com/open-telemetry/opentelemetry-specification/pull/690))

## v0.6.0 (07-01-2020)

Expand Down
2 changes: 2 additions & 0 deletions specification/trace/semantic_conventions/messaging.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ The values allowed for `<operation name>` are defined in the section [Operation
The message destination name, i.e., the name of the topic or queue, is usually a low cardinality identifier suitable to be used as a span name.
If the [conversation ID](#conversations) is expected to have lower cardinality than the message destination name, it SHOULD be used instead.
In particular, the conversation ID SHOULD be used if the message destination is unnamed or [temporary](#temporary-destinations) unless multiple conversations can be combined to a logical destination of lower cardinality.
If the conversation ID on the other hand is expected to be of too high cardinality as well, introducing an artificial destination name instead is recommended.

If the format above is used, the operation name MUST match the `messaging.operation` attribute defined for message consumer spans below.

Expand All @@ -90,6 +91,7 @@ Examples:
* `conversation-A1B2C3D4 send`
* `conversation-A1B2C3D4 receive`
* `AuthenticationRequest-Conversations process`
* `(temporary) send` (if neither the destination name nor the conversation ID have low cardinality)

### Span kind

Expand Down

0 comments on commit d742494

Please sign in to comment.