Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider allowing Trace's Context interaction to be non-static #1201

Closed
carlosalberto opened this issue Nov 6, 2020 · 2 comments
Closed

Consider allowing Trace's Context interaction to be non-static #1201

carlosalberto opened this issue Nov 6, 2020 · 2 comments
Labels
area:api Cross language API specification issue priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:context Related to the specification/context directory spec:trace Related to the specification/trace directory

Comments

@carlosalberto
Copy link
Contributor

As a follow-up to #1187 we need to consider allowing non-static methods to define the Trace's Context interaction.

This is because IIRC OTel Ruby was considering having this functionality in Tracer specifically (and in general, the question stands for languages supported in the future).

cc @mwear
@carlosalberto carlosalberto added area:api Cross language API specification issue spec:context Related to the specification/context directory spec:trace Related to the specification/trace directory priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Nov 6, 2020
@mwear
Copy link
Member

mwear commented Nov 6, 2020 •
edited
Loading

Ruby ended up implementing these as static methods on the trace module, so we don't need this to be specified. Feel free to close this issue.

@carlosalberto
Copy link
Contributor Author

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Cross language API specification issue priority:p2 Medium priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:context Related to the specification/context directory spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlosalberto @mwear