Clarify the location of tracing's Context interaction. #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosalberto
added
area:api
Oberon00
reviewed
Nov 3, 2020
Oberon00
approved these changes
Nov 3, 2020
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
|
Actually, we may need to also remove the mention of |
|
I am against removing "static". I mean I'm open to improving the wording to make it more language neutral, but a Tracer instance MUST NOT be required to interact with the current span. This often leads to misunderstandings, such as that each named tracer manages it's own active span, or complaints such as "why do I need to provide an instrumentation library name to access the current span" (#586). EDIT: I would be OK with allowing nonstatic methods on the TracerProvider. |
yurishkuro
approved these changes
Nov 3, 2020
iNikem
reviewed
Nov 4, 2020
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
|
@carlosalberto we can do a separate PR for the "static" if you feel strongly. |
bogdandrutu
approved these changes
Nov 4, 2020
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the location of the tracing interaction with
Context, i.e. we want to say that this logic can exist anywhere in the API, as long as it exists in a single place.The mention of a
TracingContextUtilsclass seemed like a too-specific suggestion, hence the removal (in Java we had this class, but ended up putting theContextinteraction as static/instanceSpandirectly).