-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonical type field for spans #16
Comments
+1 on a strongly typed field like an enum. |
Maybe related: #271 |
Discussed in the 0.3 triage party. Sometimes a span can satisfy more than one "type". Do we believe that span type is always unique? |
can you provide an example of a span with more than one type? |
I believe the discussion hypothesized a span that was both an HTTP server span and a DB client span. You could use multiple spans to reflect this reality, but it sometimes is not a good use of resources to make two spans when one will do. |
Too much has been lost to combine everything in one span. A span that is both an HTTP server span and a DB client span will have a bewildering array of attributes. Imagine the kinds of horrible programs you'd get trying to cut down call stack size by a few. |
this issue was opened long ago with the theoretic scenario in mind. Let's close and reopen if there is somebody who is willing to drive this discussion forward. |
* First draft: "named tracers" * Implement feedback. * Move named tracers proposal into text folder * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Add examples section. * Update 0000-named-tracers.md * Implement feedback from code review * Remove the implementation details about enabling / disabling ... of sensors and reduced the proposal the actual core of associating names with tracers.:q * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Reworked this RFC based on feedback on GitHub. * Implement latest review suggestions * Removed formatting * Re-introduce plain string factory and move Resource-based approach to alternatives * Use ` to format the names in the examples. * Fix typo and broken link * Extended the OTEP to included Metrics as well. * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Implement latest feedback. * Rename 0000-named-tracers.md to 0016-named-tracers.md
* First draft: "named tracers" * Implement feedback. * Move named tracers proposal into text folder * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Apply suggestions from code review Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> * Add examples section. * Update 0000-named-tracers.md * Implement feedback from code review * Remove the implementation details about enabling / disabling ... of sensors and reduced the proposal the actual core of associating names with tracers.:q * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Reworked this RFC based on feedback on GitHub. * Implement latest review suggestions * Removed formatting * Re-introduce plain string factory and move Resource-based approach to alternatives * Use ` to format the names in the examples. * Fix typo and broken link * Extended the OTEP to included Metrics as well. * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Update text/0000-named-tracers.md Co-Authored-By: Christian Neumüller <christian+github@neumueller.me> * Implement latest feedback. * Rename 0000-named-tracers.md to 0016-named-tracers.md
See discussion: #14 (comment)
The proposal is to have a strongly-typed field on a span that will define its type and ultimately - the set of attributed one should expect to see on it and interpret.
The alternative is to have a predefined attribute name for this type.
This change should be driven by scenarios we plan to enable in OpenTelemetry that will use this field. For instance, a strongly typed field can be justified by a scenario like metrics extraction from the specific span types.
The text was updated successfully, but these errors were encountered: