Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical type field for spans #16

Closed
SergeyKanzhelev opened this issue May 21, 2019 · 7 comments
Closed

Canonical type field for spans #16

SergeyKanzhelev opened this issue May 21, 2019 · 7 comments
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Milestone

Comments

@SergeyKanzhelev
Copy link
Member

See discussion: #14 (comment)

The proposal is to have a strongly-typed field on a span that will define its type and ultimately - the set of attributed one should expect to see on it and interpret.

The alternative is to have a predefined attribute name for this type.

This change should be driven by scenarios we plan to enable in OpenTelemetry that will use this field. For instance, a strongly typed field can be justified by a scenario like metrics extraction from the specific span types.

@SergeyKanzhelev SergeyKanzhelev added this to the API revision: 07-2019 milestone Jun 3, 2019
@danielkhan
Copy link
Contributor

+1 on a strongly typed field like an enum.

@iredelmeier iredelmeier added the area:semantic-conventions Related to semantic conventions label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: API revision: 07-2019, Alpha v0.3 Sep 27, 2019
@Oberon00
Copy link
Member

Oberon00 commented Oct 1, 2019

Maybe related: #271

@SergeyKanzhelev SergeyKanzhelev added this to the Alpha v0.3 milestone Oct 3, 2019
@jmacd
Copy link
Contributor

jmacd commented Jan 22, 2020

Discussed in the 0.3 triage party. Sometimes a span can satisfy more than one "type". Do we believe that span type is always unique?

@dyladan
Copy link
Member

dyladan commented Jan 22, 2020

can you provide an example of a span with more than one type?

@jmacd
Copy link
Contributor

jmacd commented Jan 22, 2020

I believe the discussion hypothesized a span that was both an HTTP server span and a DB client span. You could use multiple spans to reflect this reality, but it sometimes is not a good use of resources to make two spans when one will do.

@jmacd jmacd modified the milestones: Alpha v0.3, Alpha v0.4 Jan 29, 2020
@bogdandrutu bogdandrutu modified the milestones: v0.5, v0.6 May 26, 2020
@bogdandrutu bogdandrutu added spec:trace Related to the specification/trace directory and removed schema labels Jun 12, 2020
@carlosalberto carlosalberto added the release:after-ga Not required before GA release, and not going to work on before GA label Jul 2, 2020
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
@pauldraper
Copy link

pauldraper commented Dec 23, 2020

You could use multiple spans to reflect this reality, but it sometimes is not a good use of resources to make two spans when one will do.

Too much has been lost to combine everything in one span.

A span that is both an HTTP server span and a DB client span will have a bewildering array of attributes.

Imagine the kinds of horrible programs you'd get trying to cut down call stack size by a few.

@SergeyKanzhelev
Copy link
Member Author

this issue was opened long ago with the theoretic scenario in mind. Let's close and reopen if there is somebody who is willing to drive this discussion forward.

carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 21, 2024
* First draft: "named tracers"

* Implement feedback.

* Move named tracers proposal into text folder

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Add examples section.

* Update 0000-named-tracers.md

* Implement feedback from code review

* Remove the implementation details about enabling / disabling ... of
sensors and reduced the proposal the actual core of associating names
with tracers.:q

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Reworked this RFC based on feedback on GitHub.

* Implement latest review suggestions

* Removed formatting

* Re-introduce plain string factory and move Resource-based approach to alternatives

* Use ` to format the names in the examples.

* Fix typo and broken link

* Extended the OTEP to included Metrics as well.

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Implement latest feedback.

* Rename 0000-named-tracers.md to 0016-named-tracers.md
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 23, 2024
* First draft: "named tracers"

* Implement feedback.

* Move named tracers proposal into text folder

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>

* Add examples section.

* Update 0000-named-tracers.md

* Implement feedback from code review

* Remove the implementation details about enabling / disabling ... of
sensors and reduced the proposal the actual core of associating names
with tracers.:q

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Reworked this RFC based on feedback on GitHub.

* Implement latest review suggestions

* Removed formatting

* Re-introduce plain string factory and move Resource-based approach to alternatives

* Use ` to format the names in the examples.

* Fix typo and broken link

* Extended the OTEP to included Metrics as well.

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Update text/0000-named-tracers.md

Co-Authored-By: Christian Neumüller <christian+github@neumueller.me>

* Implement latest feedback.

* Rename 0000-named-tracers.md to 0016-named-tracers.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

9 participants