Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need "branch must be up to date" restriction? #936

Closed
yurishkuro opened this issue Sep 9, 2020 · 9 comments
Closed

Do we really need "branch must be up to date" restriction? #936

yurishkuro opened this issue Sep 9, 2020 · 9 comments
Labels
area:miscellaneous For issues that don't match any other area label spec:miscellaneous For issues that don't match any other spec label

Comments

@yurishkuro
Copy link
Member

#931 is approved, but I, as admin, cannot merge it, nor can I merge master to make it pass this check.

cc @open-telemetry/technical-committee

@yurishkuro yurishkuro added the spec:miscellaneous For issues that don't match any other spec label label Sep 9, 2020
@Oberon00
Copy link
Member

Oberon00 commented Sep 9, 2020

Duplicate of #512

@Oberon00 Oberon00 marked this as a duplicate of #512 Sep 9, 2020
@carlosalberto
Copy link
Contributor

+1 on this, as it creates too much hassle (but IIRC @bogdandrutu had a reason to enable this).

@Oberon00
Copy link
Member

Oberon00 commented Sep 9, 2020

@yurishkuro I updated the PR in question (I have access to that Dynatrace repository)

@yurishkuro
Copy link
Member Author

The reasoning in #512 is

Because we fixed the lint check (broken for 2 months) and started to merge PRs that did not pass the lint check (based on master commit that did not include the fix). This was the only option to enforce that everyone pass the lint check.

I am not convinced it's a good reason, more a reaction to one time issue where bad commits were made due to lack of lint enforcement.

@Oberon00
Copy link
Member

Oberon00 commented Sep 9, 2020

IMHO fixing the lint with quick follow-up PRs on master is easier than pinging people to update their PRs with organization-owned repos.

@carlosalberto
Copy link
Contributor

Agreed that we should perhaps revert this. @bogdandrutu You ok with that? ;)

@andrewhsu andrewhsu added the area:miscellaneous For issues that don't match any other area label label Sep 11, 2020
@andrewhsu
Copy link
Member

From the issue triage mtg today, if @open-telemetry/technical-committee can either execute this requested change or close this issue.

@carlosalberto
Copy link
Contributor

cc @SergeyKanzhelev

@SergeyKanzhelev
Copy link
Member

I'm ok reverting it. It's easier to fix issue than block PR merges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:miscellaneous For issues that don't match any other area label spec:miscellaneous For issues that don't match any other spec label
Projects
None yet
Development

No branches or pull requests

5 participants