-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we really need "branch must be up to date" restriction? #936
Comments
Duplicate of #512 |
+1 on this, as it creates too much hassle (but IIRC @bogdandrutu had a reason to enable this). |
@yurishkuro I updated the PR in question (I have access to that Dynatrace repository) |
The reasoning in #512 is
I am not convinced it's a good reason, more a reaction to one time issue where bad commits were made due to lack of lint enforcement. |
IMHO fixing the lint with quick follow-up PRs on master is easier than pinging people to update their PRs with organization-owned repos. |
Agreed that we should perhaps revert this. @bogdandrutu You ok with that? ;) |
From the issue triage mtg today, if @open-telemetry/technical-committee can either execute this requested change or close this issue. |
I'm ok reverting it. It's easier to fix issue than block PR merges |
#931 is approved, but I, as admin, cannot merge it, nor can I merge master to make it pass this check.
cc @open-telemetry/technical-committee
The text was updated successfully, but these errors were encountered: