Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Do not "Require branches to be up to date before merging" in the repository settings #512

Closed
Oberon00 opened this issue Mar 11, 2020 · 8 comments
Assignees

Comments

@Oberon00
Copy link
Member

Oberon00 commented Mar 11, 2020

I think this setting has little benefit since the spec build is unlikely to be broken because of logically but not textually conflicting PRs. On the other hand I can see a few drawbacks:

  • it is not possible to allow maintainers to update PRs that originate from an organization repository (as opposed to personal repository)
  • every time someone presses update, the diff does not change but the PR uselessly pops up in everyone's notifications.
@Oberon00 Oberon00 changed the title [meta] Do not "Require branches to be up to date before merging" [meta] Do not "Require branches to be up to date before merging" in the repository settings Mar 11, 2020
@jmacd
Copy link
Contributor

jmacd commented Mar 18, 2020

This sounds sensible.

@andrewhsu
Copy link
Member

This also sounds like a reasonable thing to me for this specification repo.

@arminru
Copy link
Member

arminru commented Apr 14, 2020

Please note that the "Allow edits from maintainers" option is not available for forks that live in organizations, it's only available for private repositories, so that won't solve the problem of merging being hindered in these cases.

@carlosalberto
Copy link
Contributor

TC decided to try this one. Lets see how it goes and adjust if/as needed ;)

@Oberon00
Copy link
Member Author

Why was this re-enabled?

@Oberon00 Oberon00 reopened this Aug 26, 2020
@bogdandrutu
Copy link
Member

bogdandrutu commented Aug 27, 2020

Because we fixed the lint check (broken for 2 months) and started to merge PRs that did not pass the lint check (based on master commit that did not include the fix). This was the only option to enforce that everyone pass the lint check.

@bogdandrutu
Copy link
Member

See #847 and #845

@bogdandrutu
Copy link
Member

Closing this issue because we explained the reasoning, and we have clear contributions guidelines that do not have this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants