-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] Do not "Require branches to be up to date before merging" in the repository settings #512
Comments
This sounds sensible. |
This also sounds like a reasonable thing to me for this specification repo. |
Please note that the "Allow edits from maintainers" option is not available for forks that live in organizations, it's only available for private repositories, so that won't solve the problem of merging being hindered in these cases. |
TC decided to try this one. Lets see how it goes and adjust if/as needed ;) |
Why was this re-enabled? |
Because we fixed the lint check (broken for 2 months) and started to merge PRs that did not pass the lint check (based on master commit that did not include the fix). This was the only option to enforce that everyone pass the lint check. |
Closing this issue because we explained the reasoning, and we have clear contributions guidelines that do not have this problem |
I think this setting has little benefit since the spec build is unlikely to be broken because of logically but not textually conflicting PRs. On the other hand I can see a few drawbacks:
The text was updated successfully, but these errors were encountered: