Fix Sampler.ShouldSample parameter descriptions. #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
bug
Oberon00
changed the title
carlosalberto
approved these changes
Aug 26, 2020
|
Overall fine. Left a pair of small, non-blocking comments. |
bogdandrutu
approved these changes
Aug 26, 2020
arminru
approved these changes
Aug 26, 2020
lzchen
approved these changes
Aug 26, 2020
|
can you please rebase so this can be merged?
|
|
@SergeyKanzhelev I thought this setting was changed in the repo following #512 (comment)? If there are no conflicts, merging should work fine even if another unrelated PR was merged after the last merge/rebase. |
cijothomas
approved these changes
Aug 26, 2020
This is why I posted the screenshot. It didn't even gave me a button "Update branch". Perhaps a GitHub glitch. Merging now as it is widely approved and uncontroversial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883.
Only non-normative changes, so no CHANGELOG entry.