Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sampler.ShouldSample parameter descriptions. #884

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Fix Sampler.ShouldSample parameter descriptions. #884

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b556c5d
Fix Sampler.ShouldSample paramter descriptions.
Oberon00 Aug 26, 2020
c3b7e2e
MUST match
Oberon00 Aug 26, 2020
952a1a0
Merge branch 'master' into samplercleanup
arminru Aug 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,12 @@ Returns the sampling Decision for a `Span` to be created.

**Required arguments:**

* `SpanContext` of a parent `Span`. Typically extracted from the wire. Can be
`null`.
* `TraceId` of the `Span` to be created. It can be different from the `TraceId`
in the `SpanContext`. Typically in situations when the `Span` to be created
starts a new Trace.
* Parent `SpanContext`. May be invalid to indicate a root span.
bogdandrutu marked this conversation as resolved.
Show resolved Hide resolved
* `TraceId` of the `Span` to be created.
If the parent `SpanContext` contains a valid `TraceId`, they MUST always match.
* Name of the `Span` to be created.
* `SpanKind`
* Initial set of `Attributes` for the `Span` being constructed
* `SpanKind` of the `Span` to be created.
* Initial set of `Attributes` of the `Span` to be created.
* Collection of links that will be associated with the `Span` to be created.
Typically useful for batch operations, see
[Links Between Spans](../overview.md#links-between-spans).
Expand Down