-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the baggage spec to include opaque metadata. #1066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Oct 6, 2020
bogdandrutu
approved these changes
Oct 6, 2020
arminru
reviewed
Oct 7, 2020
carlosalberto
approved these changes
Oct 7, 2020
anuraaga
approved these changes
Oct 7, 2020
Note: I added some additional implementation notes on the propagator, after working on an implementation. |
Please rebase |
jkwatson
force-pushed
the
baggage_update
branch
from
October 7, 2020 21:23
63098e3
to
0e0c9d4
Compare
done |
carlosalberto
added
area:api
Cross language API specification issue
release:required-for-ga
Must be resolved before GA release, or nice to have before GA
spec:baggage
Related to the specification/baggage directory
spec:context
Related to the specification/context directory
labels
Oct 7, 2020
Also update the description of the propagator to clarify metadata propagation.
…he string, not hte string itself.
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
jkwatson
force-pushed
the
baggage_update
branch
from
October 7, 2020 23:14
0e0c9d4
to
9899958
Compare
arminru
approved these changes
Oct 8, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:api
Cross language API specification issue
release:required-for-ga
Must be resolved before GA release, or nice to have before GA
spec:baggage
Related to the specification/baggage directory
spec:context
Related to the specification/context directory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update the description of the propagator to clarify metadata propagation.
Fixes #1050
Changes
Adds the concept of baggage entry metadata, and explains how to propagate the W3C baggage.