-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide semantic conventions for RPC metrics #1162
Provide semantic conventions for RPC metrics #1162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
My only question is: should the rpc metrics also include HTTP labels if the RPC calls are happening over HTTP?
5b62ed8
to
49fc789
Compare
@justinfoote Regarding RPC having HTTP labels if it's over HTTP. While Personally I could see reasons to include it or not, I think perhaps we should follow from TRACE: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/rpc.md#distinction-from-http-spans TL;DR: The metrics is more about the fact that it's an RPC then it is about HTTP GET/POST/PUT/DELETE resources, so we shouldn't cross-report. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@MrAlias Is there anything else I need to do for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@carlosalberto What else do I need to do for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an entry in CHANGELOG.md for your new semantic convention. Thanks!
@jsuereth The build checks required to pass for merging are currently saying "Waiting for status to be reported" because we switched to Github actions in the meantime. If you merge or rebase onto the current master, those changes should be picked up and the build should pass. |
1ef92f0
to
5e3cf6e
Compare
Done! |
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Fixes #1016
Changes
Adds semantic conventions for RPC metrics.
rpc.?.duration
,rpc.?.request_size
andrpc.?.response_size
, crossed byserver
orclient
Deviations from OpenCensus