Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SQL span naming suggestion: <db.operation> <db.name>.<db.sql.table> #1219

Merged
merged 10 commits into from
Nov 24, 2020

Conversation

mateuszrzeszutek
Copy link
Member

Fixes #1139

Changes

Add a suggestion that <db.operation> <db.name>.<db.sql.table> may be used for SQL DB spans; also modify the MySQL example to reflect that.

Related issues:

Related oteps: none

@iNikem
Copy link
Contributor

iNikem commented Nov 11, 2020

@mateuszrzeszutek Just to clarify: your intention is that both old-way "normalized" sql AND <db.operation> <db.name>.<db.sql.table> are OK ?

@mateuszrzeszutek
Copy link
Member Author

your intention is that both old-way "normalized" sql AND <db.operation> <db.name>.<db.sql.table> are OK ?

Hmm, I think that the whole DB span naming spec is vague intentionally and it doesn't make any sense to say "but SQL MUST be named this way". I believe that we should at the very least recommend this low-cardinality naming scheme -- so I changed MAY to RECOMMENDED.

@Oberon00
Copy link
Member

Note that RECOMMENDED is defined to mean the same as SHOULD and we usually use the latter: https://github.com/open-telemetry/opentelemetry-specification#notation-conventions-and-compliance

@mateuszrzeszutek
Copy link
Member Author

Note that RECOMMENDED is defined to mean the same as SHOULD and we usually use the latter: https://github.com/open-telemetry/opentelemetry-specification#notation-conventions-and-compliance

Right, a quick search has revealed that RECOMMENDED is hardly ever used in this project. Changed to SHOULD.

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@arminru arminru requested a review from yurishkuro November 13, 2020 08:17
Mateusz Rzeszutek and others added 2 commits November 16, 2020 12:54
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
@arminru arminru added area:semantic-conventions Related to semantic conventions release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:trace Related to the specification/trace directory labels Nov 24, 2020
@arminru arminru merged commit 9f8df20 into open-telemetry:master Nov 24, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…ble> (open-telemetry#1219)

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it okay to use SQL statement type (e.g. just "SELECT") as span name?
8 participants