-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a SQL span naming suggestion: <db.operation> <db.name>.<db.sql.table> #1219
Add a SQL span naming suggestion: <db.operation> <db.name>.<db.sql.table> #1219
Conversation
@mateuszrzeszutek Just to clarify: your intention is that both old-way "normalized" sql AND |
Hmm, I think that the whole DB span naming spec is vague intentionally and it doesn't make any sense to say "but SQL MUST be named this way". I believe that we should at the very least recommend this low-cardinality naming scheme -- so I changed MAY to RECOMMENDED. |
Note that RECOMMENDED is defined to mean the same as SHOULD and we usually use the latter: https://github.com/open-telemetry/opentelemetry-specification#notation-conventions-and-compliance |
Right, a quick search has revealed that RECOMMENDED is hardly ever used in this project. Changed to SHOULD. |
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
…ble> (open-telemetry#1219) Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Fixes #1139
Changes
Add a suggestion that
<db.operation> <db.name>.<db.sql.table>
may be used for SQL DB spans; also modify the MySQL example to reflect that.Related issues:
Related oteps: none