Suffix OTLP TIMEOUT variable with MILLIS #1319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approving as I'm ok with this approach (I think @jkwatson will like it too ;) ) cc @bogdandrutu |
carlosalberto
approved these changes
Jan 6, 2021
jkwatson
approved these changes
Jan 6, 2021
|
Superceded by #1325 - both solve the issue but that probably solves it better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1312
Changes
Suffixes OTLP timeout variables with millis for consistency with BSP variables and to allow the variable to be self-documenting in terms of what the unit of the value is.