Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowercased ECS launch types #1339

Merged
merged 9 commits into from
Jan 27, 2021
Merged

Lowercased ECS launch types #1339

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d128468
lowercased ECS launch types
Jan 14, 2021
a382574
Merge branch 'master' into lowercase-type
arminru Jan 21, 2021
c2ab7b7
Merge branch 'master' into lowercase-type
bogdandrutu Jan 26, 2021
2dc1256
Merge branch 'master' into lowercase-type
willarmiros Jan 26, 2021
1537139
updated changelog
Jan 26, 2021
1527f51
Merge branch 'master' into lowercase-type
willarmiros Jan 26, 2021
4db3950
updated tables with 2.1 tool
Jan 27, 2021
0e6701e
Merge branch 'master' into lowercase-type
bogdandrutu Jan 27, 2021
bbdea68
Merge branch 'master' into lowercase-type
bogdandrutu Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions semantic_conventions/resource/cloud_provider/aws/ecs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ groups:
allow_custom_values: false
members:
- id: ec2
value: "EC2"
value: "ec2"
- id: fargate
value: "Fargate"
value: "fargate"
brief: >
The [launch type](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/launch_types.html) for an ECS task.
examples: ['EC2', 'Fargate']
examples: ['ec2', 'fargate']
- id: task.arn
type: string
brief: >
Expand Down
6 changes: 3 additions & 3 deletions specification/resource/semantic_conventions/cloud_provider/aws/ecs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
|---|---|---|---|---|
| `aws.ecs.container.arn` | string | The Amazon Resource Name (ARN) of an [ECS container instance](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ECS_instances.html). | `arn:aws:ecs:us-west-1:123456789123:container/32624152-9086-4f0e-acae-1a75b14fe4d9` | No |
| `aws.ecs.cluster.arn` | string | The ARN of an [ECS cluster](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/clusters.html). | `arn:aws:ecs:us-west-2:123456789123:cluster/my-cluster` | No |
| `aws.ecs.launchtype` | string | The [launch type](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/launch_types.html) for an ECS task. | `EC2`; `Fargate` | No |
| `aws.ecs.launchtype` | string | The [launch type](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/launch_types.html) for an ECS task. | `ec2`; `fargate` | No |
| `aws.ecs.task.arn` | string | The ARN of an [ECS task definition](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definitions.html). | `arn:aws:ecs:us-west-1:123456789123:task/10838bed-421f-43ef-870a-f43feacbbb5b` | No |
| `aws.ecs.task.family` | string | The task definition family this task definition is a member of. | `opentelemetry-family` | No |

`aws.ecs.launchtype` MUST be one of the following:

| Value | Description |
|---|---|
| `EC2` | ec2 |
| `Fargate` | fargate |
| `ec2` | ec2 |
| `fargate` | fargate |
<!-- endsemconv -->