Consolidate OTLP variables to use TRACES / METRICS to describe talking… #1362
Conversation
… to TraceService / MetricsService
|
I'm a little bit inclined to go with |
|
We discussed in the Maintainers meeting, and chose TRACE. |
|
@open-telemetry/specs-metrics-approvers Please somebody give us a blessing here, as Metrics is also updated ;) |
There was a problem hiding this comment.
OTLP uses plural traces, metrics and logs for consistency:
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/protocol/otlp.md
@tigrannajaryan Really? I only see https://github.com/open-telemetry/opentelemetry-proto/tree/master/opentelemetry/proto |
We cannot change those name since it breaks compatibility and they are already declared stable. However, as far as I remember this was discussed and a decision was made that we should use plural for all signals going forward where we can. Collector codebase uses plural traces everywhere. OTLP/HTTP uses /v1/traces as the default URL. |
|
After a second look, agreed that we should go for |
…emetry-specification into trace-metrics-variables
bogdandrutu
changed the title
…g… (open-telemetry#1362) * Consolidate OTLP variables to use TRACE / METRICS to describe talking to TraceService / MetricsService * CHANGELOG * Quote * S * Update CHANGELOG.md Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com> Co-authored-by: Bogdan Drutu <lazy@splunk.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
… to TraceService / MetricsService
Figured we need a PR to try to knock these out :)
Fixes #1352
Fixes #1353
Changes
Environment variables for configuring OTLP exporters are changed from SPAN / METRIC to TRACE / METRICS. This is to correspond to the services being connected to, TraceService and MetricsService. It seems natural, and leaves out ambiguity by just matching up with the service names. Hopefully these variables won't be used all that much anyways in favor of the polyglot variables.