Add OTEL_EXPORTER_JAEGER_TIMEOUT environment variable #1612
Conversation
| | OTEL_EXPORTER_JAEGER_AGENT_HOST | Hostname for the Jaeger agent | "localhost" | | ||
| | OTEL_EXPORTER_JAEGER_AGENT_PORT | Port for the Jaeger agent | 6832 | | ||
| | OTEL_EXPORTER_JAEGER_ENDPOINT | HTTP endpoint for Jaeger traces | <!-- markdown-link-check-disable --> "http://localhost:14250"<!-- markdown-link-check-enable --> | | ||
| | OTEL_EXPORTER_JAEGER_TIMEOUT | Max waiting time for the backend to process each spans batch | 10s | |
There was a problem hiding this comment.
It sounds like it limits server time. Is it timeout for the exporter (client) or e.g. collector's receiver (server)?
There was a problem hiding this comment.
probably should be reworded to "Max waiting time for the backend to respond to the client for a request" or something like that.
There was a problem hiding this comment.
"Maximum time that the Jaeger exporter would wait for each batch export."
There was a problem hiding this comment.
It's probably important to call out that it's the request timeout and not a network connect timeout.
There was a problem hiding this comment.
Updated, also applied the new wording to OTEL_EXPORTER_OTLP_TIMEOUT which is where I copied this wording from to begin with 😁
|
Sorry, would you please resolve the merge conflicts? |
open-telemetry#1612 had its Changelog entry in the previous release section ;)
Adds
OTEL_EXPORTER_JAEGER_TIMEOUTenvironment variable, similar toOTEL_EXPORTER_OTLP_TIMEOUT.The Java SDK already has this as a programmatic option:
https://github.com/open-telemetry/opentelemetry-java/blob/main/exporters/jaeger/src/main/java/io/opentelemetry/exporter/jaeger/JaegerGrpcSpanExporterBuilder.java#L76-L83
and we would like to surface this as an environment variable.