Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define how Schema URL works for Resources #1692

Conversation

tigrannajaryan
Copy link
Member

This adds to the Resource SDK the concept of Schema URL proposed in OTEP 0152:
https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md

Related earlier PR that adds the Schema URL to the API:
#1666

@tigrannajaryan tigrannajaryan requested review from a team May 12, 2021 22:10
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/resource-schema branch from 6ec1495 to 353415d Compare May 12, 2021 23:03
@carlosalberto
Copy link
Contributor

@bogdandrutu I'd love to get your eyes on this change before we merge ;)

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/resource-schema branch 2 times, most recently from 3bb9e70 to 4168a42 Compare May 17, 2021 18:10
@tigrannajaryan
Copy link
Member Author

I will merge this tomorrow if I don't hear any objections.

@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/resource-schema branch 2 times, most recently from 82884b8 to 5feebb3 Compare May 18, 2021 13:58
This adds to the Resource SDK the concept of Schema URL proposed in OTEP 0152:
https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md

Related earlier PR that adds the Schema URL to the API:
open-telemetry#1666
@tigrannajaryan tigrannajaryan force-pushed the feature/tigran/resource-schema branch from 5feebb3 to fecb35a Compare May 18, 2021 14:11
@tigrannajaryan
Copy link
Member Author

Github actions are stuck, there is service degradation. Will merge once the actions pass.

@tigrannajaryan tigrannajaryan merged commit e09a088 into open-telemetry:main May 18, 2021
@tigrannajaryan tigrannajaryan deleted the feature/tigran/resource-schema branch May 18, 2021 18:43
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
This adds to the Resource SDK the concept of Schema URL proposed in OTEP 0152:
https://github.com/open-telemetry/oteps/blob/main/text/0152-telemetry-schemas.md

Related earlier PR that adds the Schema URL to the API:
open-telemetry#1666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants