Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MetricReader interface #1888

Merged
merged 26 commits into from
Sep 9, 2021
Merged

Add MetricReader interface #1888

merged 26 commits into from
Sep 9, 2021

Commits on Aug 26, 2021

  1. add MetricReader interface

    @reyang
    reyang committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    435c422 View commit details
    Browse the repository at this point in the history

  2. fix link

    @reyang
    reyang committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    f50922d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into reyang/metrics-sdk-metricreader

    @reyang
    reyang authored Aug 26, 2021
    Configuration menu
    Copy the full SHA
    38b61a4 View commit details
    Browse the repository at this point in the history

  4. add the base exporting metricreader

    @reyang
    reyang committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    7623003 View commit details
    Browse the repository at this point in the history

  5. update diagram

    @reyang
    reyang committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    b3f0fe0 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. clarify reentrancy for OnCollect

    @reyang
    reyang committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    0c2fa70 View commit details
    Browse the repository at this point in the history

  2. describe how MetricReader is registered to MeterProvider

    @reyang
    reyang committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    4e003a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Merge branch 'main' into reyang/metrics-sdk-metricreader

    @reyang
    reyang authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    d60f4ff View commit details
    Browse the repository at this point in the history

  2. Update specification/metrics/sdk.md 

    Co-authored-by: John Watson <jkwatson@gmail.com>
    @reyang @jkwatson
    reyang and jkwatson authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    6716bd7 View commit details
    Browse the repository at this point in the history

  3. Update specification/metrics/sdk.md 

    Co-authored-by: John Watson <jkwatson@gmail.com>
    @reyang @jkwatson
    reyang and jkwatson authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    c42cbc6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into reyang/metrics-sdk-metricreader

    @reyang
    reyang authored Aug 30, 2021
    Configuration menu
    Copy the full SHA
    24379f2 View commit details
    Browse the repository at this point in the history

  5. update toc

    @reyang
    reyang committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    b1b5b2c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. address review comments

    @reyang
    reyang committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    1305453 View commit details
    Browse the repository at this point in the history

  2. fix heading

    @reyang
    reyang committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ee5f5b8 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @reyang
    reyang committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    104d65a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into reyang/metrics-sdk-metricreader

    @reyang
    reyang authored Aug 31, 2021
    Configuration menu
    Copy the full SHA
    f6bff7c View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. add clarification and example for multiple readers

    @reyang
    reyang committed Sep 1, 2021
    1 Configuration menu
    Copy the full SHA
    fd9dfc4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. update the PR based on discussion during the SIG meeting

    @reyang
    reyang committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    5029131 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @reyang
    reyang committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    ee04190 View commit details
    Browse the repository at this point in the history

  3. cleanup

    @reyang
    reyang committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    b2e2fad View commit details
    Browse the repository at this point in the history

  4. clarify the wording

    @reyang
    reyang committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    86a2c6d View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. adjust wording for pull exporter

    @reyang
    reyang committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    47f74e9 View commit details
    Browse the repository at this point in the history

  2. remove base exporting metric reader, mention that it can be an option… 

    … but not required
    @reyang
    reyang committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    7977fbf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into reyang/metrics-sdk-metricreader

    @reyang
    reyang authored Sep 8, 2021
    Configuration menu
    Copy the full SHA
    756d65c View commit details
    Browse the repository at this point in the history

  4. change default exporting interval to 60sec

    @reyang
    reyang committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    68f4fdc View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Merge branch 'main' into reyang/metrics-sdk-metricreader

    @jmacd
    jmacd authored Sep 9, 2021
    Configuration menu
    Copy the full SHA
    afafa2c View commit details
    Browse the repository at this point in the history