Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain expected usage of log body #2096

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

djaglowski
Copy link
Member

Resolves #2066 and #1752

Supports #2068

Changes

Adds a note to the log data model which explains the intended usage of the Body field.

Additional Context

Extensive discussion has been had on this issue on #1613, as well as in the Log SIG group.

@djaglowski djaglowski marked this pull request as ready for review November 2, 2021 20:59
@djaglowski djaglowski requested review from a team November 2, 2021 20:59
@djaglowski
Copy link
Member Author

cc: @tigrannajaryan @pmm-sumo

@tigrannajaryan tigrannajaryan merged commit 32d6965 into open-telemetry:main Nov 4, 2021
@tigrannajaryan
Copy link
Member

I think we have enough approvals and this was unchanged for 2 days. Merging.

@tigrannajaryan
Copy link
Member

@djaglowski I copy/pasted the PR description into commit message. Please populate the commit message in future PRs.

@djaglowski djaglowski deleted the log-body branch November 4, 2021 14:39
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Resolves open-telemetry#2066 and open-telemetry#1752

Supports open-telemetry#2068

## Changes

Adds a note to the log data model which explains the intended usage of the `Body` field. 

## Additional Context

Extensive discussion has been had on this issue on [open-telemetry#1613](open-telemetry#1613 (comment)), as well as in the Log SIG group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain why structured Body is valuable in log data model
6 participants