Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of baggage in View from initial SDK specification. #2215

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

jsuereth
Copy link
Contributor

@jsuereth jsuereth commented Dec 9, 2021

Fixes #2160

Changes

  • Remove the interaction between View configuration + Baggage labels.

This is done to allow room for isntrumentation-library specification and a possible unified Trace/Metric baggage interaction semantic that would be orthogonal to what Views provide.

@jsuereth jsuereth requested review from a team December 9, 2021 15:43
@cijothomas
Copy link
Member

This doesn't prevent a user from manually accessing Baggage, and using values from it as attributes when doing counter.Add(10, {key="foo", value = ""Baggage.GetValue("foo")}), right?

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding this to changelog as well.

@jsuereth
Copy link
Contributor Author

This doesn't prevent a user from manually accessing Baggage, and using values from it as attributes when doing counter.Add(10, {key="foo", value = ""Baggage.GetValue("foo")}), right?

Yes. The idea is that any Baggage => Signal interaction probably should span Traces + Metrics + Logs and we want to save room to figure that aspect out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove baggage handling from metrics SDK for now
7 participants