Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table for well-known rpc.system values #2377

Merged
merged 6 commits into from
Mar 3, 2022
Merged

Add table for well-known rpc.system values #2377

merged 6 commits into from
Mar 3, 2022

Conversation

trask
Copy link
Member

@trask trask commented Feb 23, 2022

Changes

Adds a table for well-known rpc.system values, similar to what is done already for db.system.

This will make it easier to propose new rpc.system values, and it will also enable auto-generation of rpc.system constants similar to what is done already for db.system in some languages.

@trask trask marked this pull request as ready for review February 23, 2022 17:36
@trask trask requested review from a team February 23, 2022 17:36
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory labels Feb 23, 2022
@arminru arminru requested a review from a team March 2, 2022 13:20
@arminru arminru merged commit 038a270 into open-telemetry:main Mar 3, 2022
@trask trask deleted the well-known-rpc-systems branch March 3, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oberon00 Oberon00 Oberon00 left review comments

@yurishkuro yurishkuro yurishkuro left review comments

@cijothomas cijothomas cijothomas left review comments

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@pellared pellared pellared approved these changes

@arminru arminru arminru approved these changes

Assignees

@yurishkuro yurishkuro

Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trask @Oberon00 @bogdandrutu @yurishkuro @pellared @cijothomas @arminru