Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add process.cpu.utilization metric #2436

Merged
merged 5 commits into from
Mar 30, 2022
Merged

Add process.cpu.utilization metric #2436

merged 5 commits into from
Mar 30, 2022

Conversation

trask
Copy link
Member

@trask trask commented Mar 24, 2022

Changes

Adds process.cpu.utilization metric with definition similar to system.cpu.utilization.

@trask trask requested review from a team March 24, 2022 01:25
@trask trask mentioned this pull request Mar 24, 2022
Closed
@trask trask mentioned this pull request Mar 24, 2022
Merged
bogdandrutu
bogdandrutu reviewed Mar 24, 2022
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from semantic perspective. I still share the concern about exposing this metric from multiple language instrumentations instead of exposing it from the collector.

@trask
Copy link
Member Author

trask commented Mar 24, 2022

LGTM from semantic perspective. I still share the concern about exposing this metric from multiple language instrumentations instead of exposing it from the collector.

I opened #2439 to discuss this, hoping we can table the concern for this specific PR.

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory enhancement New feature or request labels Mar 28, 2022
bogdandrutu
bogdandrutu approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the decision to discuss what is the expectation in terms of instrumentation in a separate issue.

@bogdandrutu bogdandrutu merged commit 76f6e8e into open-telemetry:main Mar 30, 2022
@trask trask deleted the add-process-cpu-utilization branch April 8, 2022 18:35
@alanwest alanwest mentioned this pull request Dec 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@jmacd jmacd jmacd approved these changes

@arminru arminru arminru approved these changes

Assignees

@arminru arminru

Labels
area:semantic-conventions Related to semantic conventions enhancement New feature or request spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trask @bogdandrutu @jmacd @arminru