Move net.peer.name from http common to http client #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Mar 25, 2022
arminru
reviewed
Mar 28, 2022
mateuszrzeszutek
approved these changes
Mar 29, 2022
jack-berg
approved these changes
Mar 30, 2022
Oberon00
reviewed
Mar 31, 2022
arminru
approved these changes
Mar 31, 2022
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
SergeyKanzhelev
approved these changes
Mar 31, 2022
reyang
approved these changes
Apr 2, 2022
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2366
Changes
Adds note that
net.peer.nameSHOULD NOT be set if capturing it would require an extra reverse DNS lookup. And movesnet.peer.namefrom common http attributes to just client http attributes.