Move resource to SDK. #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
AloisReitbauer,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
songy23
approved these changes
Sep 21, 2019
|
Note that the latest revision of open-telemetry/oteps#16 will require resources again at the API level. |
|
@Oberon00 thanks for pointing me to that :), just added some comments about this concern there. |
|
Probably we have to rethink that association with open-telemetry/oteps#42 |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
sdkresource
branch
from
dfec7fc
to
8eab6a9
Compare
|
@SergeyKanzhelev Meter is just an interface, you associate with the implementation of the interface so "indirectly" you associate with the Meter. |
SergeyKanzhelev
approved these changes
Sep 27, 2019
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Move resource to SDK. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update readme to add the new SDK specification section Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Add propagation for trace package in the layout * Clarify the association between resource and API objects. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All updates to the specs related to https://github.com/open-telemetry/oteps/blob/master/text/0007-no-out-of-band-reporting.md. After this PR is merged the otep can probably be marked as "implemented".