Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC request/response metadata as span attributes #2874

Merged
merged 8 commits into from
Oct 20, 2022
Merged

Add gRPC request/response metadata as span attributes #2874

merged 8 commits into from
Oct 20, 2022

Conversation

samimusallam
Copy link
Member

@samimusallam samimusallam commented Oct 12, 2022 •
edited
Loading

Fixes #2843

Changes

  • Add semantic conventions for gRPC request and response metadata.

@samimusallam samimusallam requested review from a team October 12, 2022 12:53
reyang
reyang approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang
Copy link
Member

reyang commented Oct 20, 2022

Merging, this is essentially the same as the existing HTTP headers semantic convention #2843 (comment)

@reyang reyang merged commit bb15d98 into open-telemetry:main Oct 20, 2022
@samimusallam samimusallam deleted the feat/add-rpc.metadata branch October 21, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@reyang reyang reyang approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rpc.metadata for requests and responses
4 participants
@samimusallam @reyang @cijothomas @arminru