-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify MeterProvider configurable cardinality limits #2960
Specify MeterProvider configurable cardinality limits #2960
Conversation
…ication into jmacd/metrics_limits
This PR has been updated to specify the limit at the MeterProvider level. PTAL. |
Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com>
Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com>
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…ication into jmacd/metrics_limits
…-specification into jmacd/metrics_limits
/easycla |
@open-telemetry/specs-approvers Please take a look at the latest iteration. This PR has been discussed/standing for a long time now, and would be great to have it adjusted/merged soon. |
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
…ication into jmacd/metrics_limits
…-specification into jmacd/metrics_limits
@jmacd Should we include this in the May release? |
Talked to @jmacd, we are ready to roll this in. Thanks a lot for the iteration (and patience)! |
…#2960) Fixes open-telemetry#1891. **EDIT: Updated to specify cardinality limits at the View/Instrument level with a Reader-level default. Updated to use a hard limit** ## Changes Adds optional support for a maximum cardinality limit. The recommended default is 2000, based on this comment by open-telemetry#1891 (comment) @jack-berg. ~The Prometheus-WG SIG discussed this on Nov 9, 2022 and reached this recommended solution to the problem outlined in open-telemetry#1891. The consequence of exceeding these limits is in line with the current Prometheus server behavior, which drops targets that misbehave. The discussed was summarized here: open-telemetry#1891 (comment)
Fixes #1891.
EDIT: Updated to specify cardinality limits at the View/Instrument level with a Reader-level default. Updated to use a hard limit
Changes
Adds optional support for a maximum cardinality limit.
The recommended default is 2000, based on this comment by #1891 (comment) @jack-berg.
The Prometheus-WG SIG discussed this on Nov 9, 2022 and reached this recommended solution to the problem outlined in #1891. The consequence of exceeding these limits is in line with the current Prometheus server behavior, which drops targets that misbehave. The discussed was summarized here: #1891 (comment)