Don't recommend converting to prometheus base units, but do convert to full words #3019
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #2497 (comment) (and the following discussion), it isn't possible to convert from units to base units (e.g. convert milliseconds to seconds) for all metric types. This PR withdraws that recommendation.
I opened a few issues for adding units to metric names:
During that process, I didn't want to recommend converting to base units for the reasons above, but I do still think implementations should convert to full words where possible.
cc @gouthamve @jmacd