Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand pool.name in semantic conventions #3050

Merged
merged 24 commits into from
Mar 3, 2023
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0176743
Update database-metrics.md
haddasbronfman Dec 20, 2022
f78cbd9
Update specification/metrics/semantic_conventions/database-metrics.md
haddasbronfman Dec 21, 2022
e25ddd0
Update database-metrics.md
haddasbronfman Dec 21, 2022
d25b445
Merge branch 'main' into patch-1
haddasbronfman Dec 21, 2022
c601b62
Update CHANGELOG.md
haddasbronfman Dec 21, 2022
45bcf56
Merge branch 'main' into patch-1
haddasbronfman Dec 27, 2022
9290644
Merge branch 'main' into patch-1
haddasbronfman Jan 3, 2023
6b427d9
Merge branch 'main' into patch-1
haddasbronfman Jan 5, 2023
f042a89
Merge branch 'main' into patch-1
haddasbronfman Jan 12, 2023
7de0613
Merge branch 'main' into patch-1
haddasbronfman Jan 15, 2023
f3114ee
Merge branch 'main' into patch-1
haddasbronfman Jan 19, 2023
1f5fd12
Merge branch 'main' into patch-1
haddasbronfman Jan 29, 2023
e4edf74
Update specification/metrics/semantic_conventions/database-metrics.md
haddasbronfman Feb 1, 2023
170495c
Merge branch 'main' into patch-1
haddasbronfman Feb 5, 2023
b2e1b2d
Use db.connection_string
haddasbronfman Feb 9, 2023
4f3a63d
Merge branch 'main' into patch-1
haddasbronfman Feb 9, 2023
45657f8
Update specification/metrics/semantic_conventions/database-metrics.md
haddasbronfman Feb 12, 2023
30acb21
Merge branch 'main' into patch-1
haddasbronfman Feb 12, 2023
e3223b6
Merge branch 'main' into patch-1
haddasbronfman Feb 14, 2023
2bfe190
Merge branch 'main' into patch-1
haddasbronfman Feb 19, 2023
0a3b6a8
Merge branch 'main' into patch-1
haddasbronfman Feb 27, 2023
88fb7c4
Merge branch 'main' into patch-1
haddasbronfman Feb 27, 2023
7f2ab50
Merge branch 'main' into patch-1
haddasbronfman Mar 2, 2023
aad1804
Merge branch 'main' into patch-1
carlosalberto Mar 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ release.

- Rename built-in ExemplarFilters to AlwaysOn, AlwaysOff and TraceBased.
([#2919](https://github.com/open-telemetry/opentelemetry-specification/pull/2919))
- Expand the declaration of `pool.name`.
([#3050](https://github.com/open-telemetry/opentelemetry-specification/pull/3050))
- Add `MaxScale` config option to Exponential Bucket Histogram Aggregation.
([#3017](https://github.com/open-telemetry/opentelemetry-specification/pull/3017))
- Rename exponential bucket histogram aggregation to base 2 exponential histogram
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ Below is a table of the attributes that MUST be included on all connection pool

| Name | Type | Description | Examples | Requirement Level |
|-------------|--------|------------------------------------------------------------------------------|----------------|-------------------|
| `pool.name` | string | The name of the connection pool; unique within the instrumented application. | `myDataSource` | Required |
| `pool.name` | string | The name of the connection pool; unique within the instrumented application. In case the pool has no name in the monitored database, then the name should be as follows: `host: '<host>', port: <port>, database: '<database name>', user: '<user>'`. | `myDataSource`, `host: localhost port: 3306 database: db_test user: root` | Required |
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
haddasbronfman marked this conversation as resolved.
Show resolved Hide resolved