add semantic conventions for heroku #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
reviewed
Jan 9, 2023
joaopgrassi
reviewed
Jan 10, 2023
arminru
added
area:semantic-conventions
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
MovieStoreGuy
approved these changes
Jan 18, 2023
|
I just noticed, shouldn't these new conventions be inside the cloud provider's folder? |
|
I don’t know. Please tell me where this should go. Thanks! |
|
I'm not sure as well, but I'd think Heroku is a cloud provider, so would make sense to be in that folder? Not sure if the others think the same. |
arminru
reviewed
Jan 24, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
arminru
approved these changes
Feb 15, 2023
specification/resource/semantic_conventions/cloud_provider/heroku.md
Outdated
Show resolved
Hide resolved
arminru
reviewed
Feb 15, 2023
|
/label -stale |
joaopgrassi
approved these changes
Feb 20, 2023
arminru
approved these changes
Feb 21, 2023
specification/resource/semantic_conventions/cloud_provider/heroku.md
Outdated
Show resolved
Hide resolved
…oku.md Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
arminru
approved these changes
Feb 22, 2023
specification/resource/semantic_conventions/cloud_provider/heroku.md
Outdated
Show resolved
Hide resolved
specification/resource/semantic_conventions/cloud_provider/heroku.md
Outdated
Show resolved
Hide resolved
arminru
approved these changes
Feb 27, 2023
jsuereth
pushed a commit
to jsuereth/opentelemetry-specification
that referenced
this pull request
Feb 28, 2023
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3032
Changes
Adds a list of resource attributes characterizing a Heroku dyno environment, taken after https://devcenter.heroku.com/articles/dyno-metadata