Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Variables to setup TLS Client #3080

Closed
wants to merge 1 commit into from

Conversation

mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Jan 5, 2023

Changes

Add new environement variables :

  • OTEL_EXPORTER_ZIPKIN_CERTIFICATE
  • OTEL_EXPORTER_ZIPKIN_CLIENT_KEY
  • OTEL_EXPORTER_ZIPKIN_CLIENT_CERTIFICATE

Theses variables are based on the existing OTLP variables from here

Related to open-telemetry/opentelemetry-java#5085

@mmorel-35 mmorel-35 requested review from a team January 5, 2023 16:13
@tigrannajaryan
Copy link
Member

There is currently a moratorium (with exceptions possible) on env variables: #2891 (comment)

Please read the moratorium rules and if you believe the changes in PR don't fall under the specified rules then the PR can be reviewed.

@mmorel-35
Copy link
Author

Hi @tigrannajaryan ,

I saw the comment, but except if I misunderstood, I don't think the variables I'm proposing are blocked by the quoted criteria.
Do you have different perception ?

@mmorel-35 mmorel-35 force-pushed the patch-1 branch 2 times, most recently from b24753f to 18b5990 Compare January 7, 2023 12:30
@tigrannajaryan
Copy link
Member

Hi @tigrannajaryan ,

I saw the comment, but except if I misunderstood, I don't think the variables I'm proposing are blocked by the quoted criteria. Do you have different perception ?

I had a quick look at the PR and I think it may be accepted as an exception to moratorium since it is very similar to env variable that we already have for OTLP.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants