Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanprocessors / TracerFactory #313

Merged

Conversation

z1c0
Copy link
Contributor

@z1c0 z1c0 commented Oct 16, 2019

Update SDK spec regarding span processors and Tracers / TracerFactories.

Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation of this limitation? I understand that it simplifies the implementation, but from the scenarios perspective I can imagine scenarios when user wants to enrich data or apply a custom filter for a specific tracer. Is it not a valid scenario?

Also, is the same limitation applied for samplers?

@SergeyKanzhelev SergeyKanzhelev added this to the Alpha v0.3 milestone Oct 16, 2019
@z1c0
Copy link
Contributor Author

z1c0 commented Oct 17, 2019

This is actually not about simplifying the implementation but to have a well-defined and comprehensible specification how all Tracers created by the same Tracer factory must behave. It's less confusing if Tracers created by the same factory also share the same properties and configuration, hence behavior.
In the case where one might want to treat a Tracer differently:

  • An additional TracerFactory can be used.
  • SpanProcessors can use the tracer name and version for that.

I will look into Sampling and Propagators separately to have more focused PRs.

@SergeyKanzhelev
Copy link
Member

If we will find out that per-Tracer processors are important we can introduce them later.

@SergeyKanzhelev
Copy link
Member

This PR has enough sign offs from diverse set of companies. And it was active for at least 2 business days. Merging

SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
* Update SDK Tracing spec in regards to shared communication objects.

* Clarified documentation on configuration objects.
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Update SDK Tracing spec in regards to shared communication objects.

* Clarified documentation on configuration objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants