-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanprocessors / TracerFactory #313
Spanprocessors / TracerFactory #313
Conversation
Update SDK Tracing spec in regards to shared communication objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation of this limitation? I understand that it simplifies the implementation, but from the scenarios perspective I can imagine scenarios when user wants to enrich data or apply a custom filter for a specific tracer. Is it not a valid scenario?
Also, is the same limitation applied for samplers?
This is actually not about simplifying the implementation but to have a well-defined and comprehensible specification how all Tracers created by the same Tracer factory must behave. It's less confusing if Tracers created by the same factory also share the same properties and configuration, hence behavior.
I will look into Sampling and Propagators separately to have more focused PRs. |
If we will find out that per-Tracer processors are important we can introduce them later. |
This PR has enough sign offs from diverse set of companies. And it was active for at least 2 business days. Merging |
* Update SDK Tracing spec in regards to shared communication objects. * Clarified documentation on configuration objects.
* Update SDK Tracing spec in regards to shared communication objects. * Clarified documentation on configuration objects.
Update SDK spec regarding span processors and Tracers / TracerFactories.