Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AWS S3 semantic conventions #3251

Merged
merged 7 commits into from
Mar 22, 2023
Merged

Added AWS S3 semantic conventions #3251

merged 7 commits into from
Mar 22, 2023

Conversation

AlexanderWert
Copy link
Member

Fixes #3193

Changes

Adds S3 related attributes to the AWS SDK semantic conventions.

Related issues:

@AlexanderWert AlexanderWert requested review from a team February 23, 2023 14:43
@AlexanderWert
Copy link
Member Author

@willarmiros , @arminru FYI

@arminru arminru added spec:trace Related to the specification/trace directory area:semantic-conventions Related to semantic conventions labels Feb 28, 2023
@AlexanderWert AlexanderWert mentioned this pull request Mar 6, 2023
Closed
4 tasks
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 9, 2023
@AlexanderWert
Copy link
Member Author

@open-telemetry/specs-approvers Can we get some review before this PR gets auto-closed? (Or extending it somehow?) Thank you!

@github-actions github-actions bot removed the Stale label Mar 10, 2023
jsuereth
jsuereth approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on discussion, I think this seems fine to add AWS-specific requests for these, as I don't see uniformity is storage provider attributes here. I think from an o11y perspective, it's almost better for the AWS specific info to show up (as it would aide in using AWS to debug what happened on their end). I see needing similar attributes for Google's cloud storage solutions.

lmolkova
lmolkova approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, from Azure perspective, we'd want to provide similar attributes, but unifying them across cloud providers does not seem to improve user experience.

@AlexanderWert
Copy link
Member Author

@open-telemetry/specs-approvers Could someone trigger / approve the CI, please?
If there are no more comments, is it ready to be merged?

@AlexanderWert
Copy link
Member Author

Seems that the failed link check is not related to files changed in this PR:
image

What can I do to fix it?

@AlexanderWert
Copy link
Member Author

OK, I see it's related to #3327. Once that PR is merged, the CI for this PR should be green again.

@reyang reyang merged commit 05cd8e0 into open-telemetry:main Mar 22, 2023
@AlexanderWert AlexanderWert mentioned this pull request May 25, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oberon00 Oberon00 Oberon00 left review comments

@jsuereth jsuereth jsuereth approved these changes

@lmolkova lmolkova lmolkova approved these changes

@reyang reyang reyang approved these changes

Assignees

@jsuereth jsuereth

Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add S3 attributes to the semantic conventions for AWS SDK
6 participants
@AlexanderWert @jsuereth @Oberon00 @lmolkova @reyang @arminru