BREAKING: Remove messaging.consumer.id, make messaging.client_id generic
#3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
reviewed
Mar 23, 2023
kenfinnigan
reviewed
Mar 23, 2023
arminru
added
semconv:messaging
spec:trace
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
pyohannes
force-pushed
the
messaging_attributes_client_id
branch
from
521d14a
to
9ec400b
Compare
kenfinnigan
suggested changes
Apr 13, 2023
kenfinnigan
approved these changes
Apr 14, 2023
joaopgrassi
reviewed
Apr 20, 2023
joaopgrassi
approved these changes
Apr 20, 2023
Oberon00
approved these changes
Apr 21, 2023
|
Thanks, I think this should indeed solve #2015. |
lmolkova
approved these changes
Apr 21, 2023
carlosalberto
approved these changes
Apr 24, 2023
|
CHANGELOG entry, please ;) |
pyohannes
force-pushed
the
messaging_attributes_client_id
branch
from
cafb8a2
to
2c970cd
Compare
@carlosalberto Done. |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…generic (open-telemetry#3336) Fixes open-telemetry#2015 ## Changes Based on discussions in the messaging workgroup and in issue open-telemetry#2015, this PR proposes to remove `messaging.consumer.id`, and to replace both `messaging.kafka.client_id` and `messaging.rocketmq.client_id` with a generic `messaging.client_id`. `messaging.consumer.id` is defined to always be set to the `client_id` of the used messaging system, except for Kafka, where it was defined to be a combination of `messaging.kafka.client_id` and `messaging.kafka.consumer.group`, or just the latter if `messaging.kafka.client_id` is not available. With this definition, the semantics of `consumer.id` are different between messaging systems, and even different for different Kafka scenarios. The proposed `messaging.client_id` has consistent semantics ("an unique client id, when it is available"), and can be used instead of `messaging.consumer.id` in almost all cases. In addition to have consistent semantics, this also simplifies the semantic conventions, as instead of `messaging.consumer.id` `messaging.kafka.client_id` `messaging.rocketmq.client_id` there is now just: `messaging.client_id`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2015
Changes
Based on discussions in the messaging workgroup and in issue #2015, this PR proposes to remove
messaging.consumer.id, and to replace bothmessaging.kafka.client_idandmessaging.rocketmq.client_idwith a genericmessaging.client_id.messaging.consumer.idis defined to always be set to theclient_idof the used messaging system, except for Kafka, where it was defined to be a combination ofmessaging.kafka.client_idandmessaging.kafka.consumer.group, or just the latter ifmessaging.kafka.client_idis not available. With this definition, the semantics ofconsumer.idare different between messaging systems, and even different for different Kafka scenarios.The proposed
messaging.client_idhas consistent semantics ("an unique client id, when it is available"), and can be used instead ofmessaging.consumer.idin almost all cases.In addition to have consistent semantics, this also simplifies the semantic conventions, as instead of
messaging.consumer.idmessaging.kafka.client_idmessaging.rocketmq.client_idthere is now just:
messaging.client_id.