Add microbenchmarks to perf benchmark doc #3696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Sep 20, 2023
MrAlias
reviewed
Sep 21, 2023
This was referenced Sep 26, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
martinkuba
force-pushed
the
microbenchmark-test
branch
from
20b5d1d to
6eeb97f
Compare
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
not stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The performance benchmark tests described in the Performance Benchmark doc are not implemented by most (if any) SDKs, likely due to the complexity and many variables that these tests have to account for.
This change updates the document with a guideline for implementing microbenchmark tests. Many SDKs already have microbenchmark tests implemented. This intent with this change is to describe some basic tests that all SDKs should implement. At this point, I am adding only a single test, but this can be extended over time.