Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark exemplars as stable. #3870

Merged
merged 8 commits into from
Apr 20, 2024
Merged

Mark exemplars as stable. #3870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4c93a64
Mark exemplars as stable.
jsuereth Feb 8, 2024
71d8fff
Merge remote-tracking branch 'origin/main' into wip-stabilize-exemplars
jsuereth Mar 21, 2024
375fe44
Fix python compliance.
jsuereth Mar 21, 2024
b6ce477
Second attempt to fix compliance matrix.
jsuereth Mar 21, 2024
06dc92a
Add changelog entry.
jsuereth Mar 21, 2024
424605d
Merge branch 'main' into wip-stabilize-exemplars
reyang Apr 11, 2024
1f68d42
Merge branch 'main' into wip-stabilize-exemplars
reyang Apr 16, 2024
fcb571c
Merge branch 'main' into wip-stabilize-exemplars
reyang Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,12 @@ release.

### Metrics

- Change the exemplar behavior to be on by default.
([#3994](https://github.com/open-telemetry/opentelemetry-specification/pull/3994))
- Add name suggestion for option to apply resource attributes as metric attributes in Prometheus exporter.
([#3837](https://github.com/open-telemetry/opentelemetry-specification/pull/3837))
- Mark Exemplars as stable.
([#3870](https://github.com/open-telemetry/opentelemetry-specification/pull/3870))

### Logs

Expand Down Expand Up @@ -51,8 +55,6 @@ release.
([#3872](https://github.com/open-telemetry/opentelemetry-specification/pull/3872))
- Add synchronous gauge entry to sum monotonic table.
([#3977](https://github.com/open-telemetry/opentelemetry-specification/pull/3977))
- Change the exemplar behavior to be on by default.
([#3994](https://github.com/open-telemetry/opentelemetry-specification/pull/3994))

### Logs

Expand Down
4 changes: 2 additions & 2 deletions spec-compliance-matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ formats is required. Implementing more than one format is optional.
| Exemplars retain any attributes available in the measurement that are not preserved by aggregation or view configuration. | | | + | | - | | + | | | | - | |
| Exemplars contain the associated trace id and span id of the active span in the Context when the measurement was taken. | | | + | | - | | + | | | | - | |
| Exemplars contain the timestamp when the measurement was taken. | | | + | | - | | + | | | | - | |
| The metrics SDK provides an `ExemplarReservoir` interface or extension point. | X | | - | | - | | + | + | | | - | |
| An `ExemplarReservoir` has an `offer` method with access to the measurement value, attributes, `Context` and timestamp. | X | | - | | - | | + | + | | | - | |
| The metrics SDK provides an `ExemplarReservoir` interface or extension point. | | | - | | - | | + | + | | | - | |
| An `ExemplarReservoir` has an `offer` method with access to the measurement value, attributes, `Context` and timestamp. | | | - | | - | | + | + | | | - | |
| The metrics SDK provides a `SimpleFixedSizeExemplarReservoir` that is used by default for all aggregations except `ExplicitBucketHistogram`. | | | + | | - | | + | + | | | - | |
| The metrics SDK provides an `AlignedHistogramBucketExemplarReservoir` that is used by default for `ExplicitBucketHistogram` aggregation. | | | + | | - | | + | | | | - | |
| A metric Producer accepts an optional metric Filter | | | | | | | - | | | | | |
Expand Down
4 changes: 2 additions & 2 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ The SDK MUST accept the following stream configuration parameters:
user does not provide an `aggregation` value, the `MeterProvider` MUST apply
a [default aggregation](#default-aggregation) configurable on the basis of
instrument type according to the [MetricReader](#metricreader) instance.
* **Status**: [Experimental, Feature-freeze](../document-status.md) - `exemplar_reservoir`: A
* `exemplar_reservoir`: A
functional type that generates an exemplar reservoir a `MeterProvider` will
use when storing exemplars. This functional type needs to be a factory or
callback similar to aggregation selection functionality which allows
Expand Down Expand Up @@ -957,7 +957,7 @@ series and the topic requires further analysis.

## Exemplar
reyang marked this conversation as resolved.
Show resolved Hide resolved

**Status**: [Experimental, Feature-freeze](../document-status.md)
**Status**: [Stable](../document-status.md)
jack-berg marked this conversation as resolved.
Show resolved Hide resolved

Exemplars are example data points for aggregated data. They provide specific
context to otherwise general aggregations. Exemplars allow correlation between
Expand Down
Loading