Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify metric point #3906

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Clarify metric point #3906

merged 5 commits into from
Feb 28, 2024

Conversation

reyang
Copy link
Member

@reyang reyang commented Feb 26, 2024 •
edited
Loading

Related to #3866.

I think this is an editorial change, so I didn't update changelog.

  1. Added a brief explanation to the existing Metric Points section (mainly for folks who followed the links in the SDK spec and came to this section).
  2. Changed "points" to "Points".
  3. Updated the links in the SDK spec.

@reyang reyang requested review from a team February 26, 2024 23:42
@reyang reyang added the spec:metrics Related to the specification/metrics directory label Feb 26, 2024
@reyang reyang mentioned this pull request Feb 27, 2024
Closed
@reyang reyang added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Feb 27, 2024
trask
trask approved these changes Feb 27, 2024
View reviewed changes
specification/metrics/data-model.md Outdated Show resolved Hide resolved
reyang and others added 2 commits February 27, 2024 16:24
@reyang reyang merged commit 7eea730 into open-telemetry:main Feb 28, 2024
7 checks passed
jaydeluca pushed a commit to jaydeluca/opentelemetry-specification that referenced this pull request Feb 29, 2024
@reyang @jaydeluca
Clarify metric point (open-telemetry#3906)
6ffa599
@reyang reyang mentioned this pull request Sep 27, 2024
Merged
5 tasks
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@reyang
Clarify metric point (open-telemetry#3906)
af8d0fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@cijothomas cijothomas cijothomas approved these changes

@trask trask trask approved these changes

Assignees

@tigrannajaryan tigrannajaryan

Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reyang @trask @cijothomas @joaopgrassi @utpilla @tigrannajaryan