New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomness requirements following W3C Trace Context level 2 #4162

Merged

reyang merged 44 commits into open-telemetry:main from jmacd:jmacd/sampling_new

Feb 13, 2025

Contributor

jmacd commented Jul 25, 2024 •

edited

Loading

Changes

Updates Trace SDK and Propagator specifications with

List W3C propagator requirements (e.g., should propagate tracestate)
Introduce W3C Trace Context Level 2 w/ the Random flag
Define explicit randomness feature from OTEP 235, OTEP 261
Trace SDK default ID generator should include 56 bits of randomness in the correct location
Trace SDK for root spans: either set the random flag to confirm the above, or use an explicit randomness value.

Part of #1413.
Part of #3602.

Product of the Sampling SIG members @kentquirk @kalyanaj @oertl @PeterF778 @yuanyuanzhao3 and myself.

jmacd commented

View reviewed changes

specification/trace/sdk.md Show resolved Hide resolved

jmacd changed the title ~~Draft rules for span context in Trace Context level 2~~ Randomness requirements for W3C Trace Context level 2

jmacd changed the title ~~Randomness requirements for W3C Trace Context level 2~~ Randomness requirements following W3C Trace Context level 2

This was referenced Jul 29, 2024

OpenTelemetry TraceIdRatioBased sampler requirements following OTEP 235 #4166

Draft

Prototype for W3C Trace Context Level 2 support in TraceIDRatioBased sampler open-telemetry/opentelemetry-go#5645

Closed


          rebase

71750cd

jmacd force-pushed the jmacd/sampling_new branch from fa9ec4c to 71750cd Compare

July 29, 2024 23:22

jmacd marked this pull request as ready for review

July 29, 2024 23:24

jmacd requested review from a team

July 29, 2024 23:24

github-actions bot assigned jack-berg

marcalff reviewed

View reviewed changes

Member

marcalff left a comment

See nit comment about text formatting, for diff

specification/trace/sdk.md Outdated Show resolved Hide resolved


          line breaks

3c4b8fa

marcalff approved these changes

View reviewed changes

Member

marcalff left a comment

LGTM.

trask reviewed

View reviewed changes

specification/trace/sdk.md Outdated Show resolved Hide resolved

kentquirk reviewed

View reviewed changes

specification/context/api-propagators.md Outdated Show resolved Hide resolved

specification/trace/tracestate-handling.md Outdated Show resolved Hide resolved

specification/trace/tracestate-handling.md Show resolved Hide resolved

oertl reviewed

View reviewed changes

specification/trace/tracestate-handling.md Outdated Show resolved Hide resolved

pellared reviewed

View reviewed changes

specification/context/api-propagators.md Outdated Show resolved Hide resolved

jmacd and others added 7 commits

August 7, 2024 07:47


          Merge branch 'main' of github.com:open-telemetry/opentelemetry-specif…

a73e378

…ication into jmacd/sampling_new


          revise trace randomness requirements for clarity

c174e36


          Apply suggestions from code review

93dcd7a

Thanks

Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Kent Quirk <kentquirk@gmail.com>


          clarify which contexts for each requirement

76c6c71


          Merge branch 'jmacd/sampling_new' of github.com:jmacd/opentelemetry-s…

d1784fa

…pecification into jmacd/sampling_new


          user-defined explicit randomness: may

b9ec958


          lowercase hex only

6a2d6c5

github-actions bot commented Aug 15, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

jmacd removed the Stale label


          Merge branch 'main' of github.com:open-telemetry/opentelemetry-specif…

01d5aac

…ication into jmacd/sampling_new

carlosalberto removed the Stale label

github-actions bot commented Dec 17, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

github-actions bot commented Dec 25, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

github-actions bot closed this

yuanyuanzhao3 mentioned this pull request

REQUEST: New membership for yuanyuanzhao3 open-telemetry/community#2531

Closed

6 tasks


          Merge branch 'main' of github.com:open-telemetry/opentelemetry-specif…

41289ab

…ication into jmacd/sampling_new

jmacd reopened this

jmacd added 2 commits

February 3, 2025 16:42


          Whitespace

6d60d5b


          be explicit about why lowercase

57442c6

jmacd marked this pull request as ready for review

February 4, 2025 00:55

jmacd mentioned this pull request

Composite Head Samplers #4321

Open

yuanyuanzhao3 reviewed

View reviewed changes

specification/trace/tracestate-handling.md Outdated Show resolved Hide resolved

carlosalberto removed the Stale label

jmacd and others added 2 commits

February 6, 2025 14:02


          Merge branch 'main' of github.com:open-telemetry/opentelemetry-specif…

…ication into jmacd/sampling_new

TOC

77df4f2

trask added the changelog.opentelemetry.io label

jpkrohling approved these changes

View reviewed changes

Member

jpkrohling left a comment

LGTM, I don't see anything contentious in this PR. I'd probably prefer having a bit more context on the example shown in the PR, but that's not strictly necessary.

specification/trace/tracestate-handling.md Show resolved Hide resolved

jmacd added 3 commits

February 12, 2025 12:04


          Merge branch 'main' of github.com:open-telemetry/opentelemetry-specif…

bc96d71

…ication into jmacd/sampling_new


          Adds more detail in the tracestate-handling example.

ffebc0a


          trailing ws

d9dd09f

jpkrohling approved these changes

View reviewed changes

Member

jpkrohling left a comment

LGTM!


          edit as group

dfe735d

Contributor Author

jmacd commented Feb 13, 2025

@open-telemetry/specs-trace-approvers I believe this is ready to merge.

reyang merged commit 8155988 into open-telemetry:main

5 of 6 checks passed

carlosalberto mentioned this pull request

Release 1.42.0 #4410

Merged

marcalff mentioned this pull request

Support for "random trace id" flag in trace context open-telemetry/opentelemetry-cpp#2283

Open

carlosalberto added a commit that referenced this pull request


          Release 1.42.0 (#4410)

eb2f6ea

February 2025 Release.

### Traces

- Deprecate `exception.escaped` attribute, add link to in-development
semantic-conventions
  on how to record errors across signals.

([#4368](#4368))
- Define randomness value requirements for W3C Trace Context Level 2.

([#4162](#4162))

### Logs

- Define how SDK implements `Logger.Enabled`.

([#4381](#4381))
- Logs API should have functionality for reusing Standard Attributes.

([#4373](#4373))

### SDK Configuration

- Define syntax for escaping declarative configuration environment
variable
  references.

([#4375](#4375))
- Resolve various declarative config TODOs.

([#4394](#4394))

cijothomas pushed a commit to cijothomas/opentelemetry-specification that referenced this pull request


          Release 1.42.0 (open-telemetry#4410)

cdc86be

February 2025 Release.

- Deprecate `exception.escaped` attribute, add link to in-development
semantic-conventions
  on how to record errors across signals.

([open-telemetry#4368](open-telemetry#4368))
- Define randomness value requirements for W3C Trace Context Level 2.

([open-telemetry#4162](open-telemetry#4162))

- Define how SDK implements `Logger.Enabled`.

([open-telemetry#4381](open-telemetry#4381))
- Logs API should have functionality for reusing Standard Attributes.

([open-telemetry#4373](open-telemetry#4373))

- Define syntax for escaping declarative configuration environment
variable
  references.

([open-telemetry#4375](open-telemetry#4375))
- Resolve various declarative config TODOs.

([open-telemetry#4394](open-telemetry#4394))

cijothomas pushed a commit to cijothomas/opentelemetry-specification that referenced this pull request


          Release 1.42.0 (open-telemetry#4410)

98c09d9

February 2025 Release.

- Deprecate `exception.escaped` attribute, add link to in-development
semantic-conventions
  on how to record errors across signals.

([open-telemetry#4368](open-telemetry#4368))
- Define randomness value requirements for W3C Trace Context Level 2.

([open-telemetry#4162](open-telemetry#4162))

- Define how SDK implements `Logger.Enabled`.

([open-telemetry#4381](open-telemetry#4381))
- Logs API should have functionality for reusing Standard Attributes.

([open-telemetry#4373](open-telemetry#4373))

- Define syntax for escaping declarative configuration environment
variable
  references.

([open-telemetry#4375](open-telemetry#4375))
- Resolve various declarative config TODOs.

([open-telemetry#4394](open-telemetry#4394))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pellared pellared left review comments

PeterF778 PeterF778 approved these changes

yuanyuanzhao3 yuanyuanzhao3 approved these changes

marcalff marcalff approved these changes

kalyanaj kalyanaj approved these changes

carlosalberto carlosalberto approved these changes

lmolkova lmolkova approved these changes

dashpole dashpole approved these changes

dyladan dyladan approved these changes

kentquirk kentquirk approved these changes

oertl oertl approved these changes

jpkrohling jpkrohling approved these changes

reyang reyang approved these changes

trask trask approved these changes

tsloughter tsloughter approved these changes

Labels

changelog.opentelemetry.io