Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Add type column to all environment variables #4336

Merged
merged 10 commits into from
Dec 21, 2024

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Dec 11, 2024

Related to #4283.

A comment adding a "type" column to each env var, but didn't feel appropriate to extend scope of #4331.

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, just typographical thoughts

specification/protocol/exporter.md Outdated Show resolved Hide resolved
specification/configuration/sdk-environment-variables.md Outdated Show resolved Hide resolved
specification/configuration/sdk-environment-variables.md Outdated Show resolved Hide resolved
specification/configuration/sdk-environment-variables.md Outdated Show resolved Hide resolved
specification/metrics/sdk_exporters/otlp.md Outdated Show resolved Hide resolved
specification/configuration/sdk-environment-variables.md Outdated Show resolved Hide resolved
@pellared
Copy link
Member

Related to #4284.

#4283?

@pellared pellared added the editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind. label Dec 20, 2024
@carlosalberto carlosalberto merged commit d1c6aec into open-telemetry:main Dec 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants