Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FOSSA scanning workflow #4420

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

opentelemetrybot
Copy link
Contributor

@opentelemetrybot opentelemetrybot requested review from a team as code owners February 18, 2025 03:47
@pellared
Copy link
Member

pellared commented Feb 18, 2025

@trask, why have you added the additional spaces? What is wrong with a single space? This is what I am used to and AFAIK it works fine for both Renovate and Dependabot.

@trask
Copy link
Member

trask commented Feb 18, 2025

@trask, why have you added the additional spaces? What is wrong with a single space? This is what I am used to and AFAIK it works fine for both Renovate and Dependabot.

I totally agree! but this repo has some kind of yaml lint validation that raises a warning inline on your PR if you don't have two spaces before the comment

@reyang reyang merged commit c65b2b6 into open-telemetry:main Feb 18, 2025
6 checks passed
@trask trask mentioned this pull request Feb 18, 2025
jsuereth pushed a commit that referenced this pull request Feb 19, 2025
For your consideration.

Related to the confusion here:
#4420 (comment)
cijothomas pushed a commit to cijothomas/opentelemetry-specification that referenced this pull request Feb 19, 2025
For your consideration.

Related to the confusion here:
open-telemetry#4420 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants