Define handling of null and empty attribute values #459
Conversation
arminru
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
There was a problem hiding this comment.
I wonder if metrics also need this kind of clarification.
CC @jmacd
Related: open-telemetry/opentelemetry-go#320
Co-Authored-By: Wolfgang Ziegler <wolfgang.ziegler@dynatrace.com>
Co-Authored-By: Christian Neumüller <christian.neumueller@dynatrace.com>
Co-Authored-By: Christian Neumüller <christian.neumueller@dynatrace.com>
arminru
force-pushed
the
attribute-null-empty
branch
from
f625245
to
c4beea2
Compare
| considered meaningful and MUST be stored and passed on to span processors / exporters. | ||
| Attribute values of `null` are considered to be not set and get discarded as if | ||
| that `SetAttribute` call had never been made. | ||
| As an exception to this, if overwriting of values is supported, this results in |
There was a problem hiding this comment.
if overwriting of values is supported...
The paragraph above says that attribute overwriting SHOULD be supported, so I think there is no need for this conditional.
There was a problem hiding this comment.
Technically it is not but I still think this clarification might avoid some potential confusion.
| This is required for map/dictionary structures represented as two arrays with | ||
| indices that are kept in sync (e.g., two attributes `header_keys` and `header_values`, | ||
| both containing an array of strings to represent a mapping | ||
| `header_keys[i] -> header_values[i]`). |
|
last sign off was from two days back. And we have enough sign offs. @bogdandrutu I remember you mentioned you want to use |
|
Looks like this could be added to the v0.4 milestone because this was merged after v0.3 was cut. |
* Define handling of null and empty attribute values * undefined -> not set * Apply suggestions from code review Co-Authored-By: Wolfgang Ziegler <wolfgang.ziegler@dynatrace.com> * Apply suggestions from code review Co-Authored-By: Christian Neumüller <christian.neumueller@dynatrace.com> * Allow exporters to replace null values in arrays * Apply suggestions from code review Co-Authored-By: Christian Neumüller <christian.neumueller@dynatrace.com> * attribute semantics -> restrictions * emphasize MUST Co-authored-by: Wolfgang Ziegler <wziegler@live.at> Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Resolves #431.
A follow-up PR might reference this definition for resource attributes as well to address #446.