SpanContext.IsRemote is false on remote children #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toumorokoshi
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
The IsRemote flag should be false on children of remote spans, as the span itself was created locally.
toumorokoshi
force-pushed
the
feature/document-isremote
branch
from
e20ce29 to
53d4dbf
Compare
yurishkuro
approved these changes
Mar 31, 2020
arminru
reviewed
Mar 31, 2020
specification/api-tracing.md
Outdated
| @@ -178,7 +178,7 @@ the same trace. | |||
| TraceID and a non-zero SpanID. | |||
|
|
|||
| `IsRemote` is a boolean flag which returns true if the SpanContext was propagated | |||
| from a remote parent. | |||
| from a remote parent. A child of a remote span should have IsRemote set to false. | |||
There was a problem hiding this comment.
Suggested change
| from a remote parent. A child of a remote span should have IsRemote set to false. | |
| from a remote parent. | |
| When creating children from remote spans, their IsRemote flag MUST be set to false. |
Otherwise one could interpret this as "The child span's IsRemote flag must always be false if the parent used to be remote, even after the child was propagated.".
There was a problem hiding this comment.
good point, thank you!
There was a problem hiding this comment.
Why only "from remote spans"? I think this part is redundant. Of course when creating children from local spans, their IsRemote flag MUST also be false.
There was a problem hiding this comment.
Actually, what about spans that are no children at all, but root spans? Of course their IsRemote flag MUST also be false. I think we should try to find a better way to phrase this.
Otherwise one could interpret this as "The child span's IsRemote flag must always be false if the parent used to be remote, even after the child was propagated.". Co-Authored-By: Armin Ruech <armin.ruech@gmail.com>
arminru
approved these changes
Mar 31, 2020
bogdandrutu
approved these changes
Apr 1, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* SpanContext.IsRemote is false on remote children The IsRemote flag should be false on children of remote spans, as the span itself was created locally. * Update specification/api-tracing.md Otherwise one could interpret this as "The child span's IsRemote flag must always be false if the parent used to be remote, even after the child was propagated.". Co-Authored-By: Armin Ruech <armin.ruech@gmail.com> Co-authored-by: Armin Ruech <armin.ruech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IsRemote flag should be false on children of remote spans,
as the span itself was created locally.
Fixes #523