Makefile fixes #615
Merged
Makefile fixes #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
arminru,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
|
The link check has a problem, cannot pass multiple files will only check the first one: |
added 2 commits
May 19, 2020 17:29
bogdandrutu
approved these changes
May 20, 2020
|
Frustratingly, the markdownlint rule does not run for me locally, spews a bunch of errors. But it passes on circleci, and I can't see why. In any case, the result of installing all these tools is that you have a "node_modules" subdirectory, which also contains a bunch of |
arminru
approved these changes
May 20, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Makefile fixes * Use a for-loop * Fix markdownlint too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile isn't running the spelling and link-check tools correctly. This fixes it.