Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ZPagesProcessor mentioned in SDK spec #683

Merged

Conversation

arminru
Copy link
Member

@arminru arminru commented Jul 1, 2020

The diagram was taken over from the OpenCensus spec and never updated, thus the OpenCensus ZPagesProcessor is still depicted there but not mentioned anywhere else in the spec.

There is currently an effort to get zPages into OTel as an experimental feature (see https://github.com/open-telemetry/oteps/blob/master/text/0110-z-pages.md), so this might be re-added in future once zPages makes it into the OTel spec as a standard feature.

@arminru arminru added the area:sdk Related to the SDK label Jul 1, 2020
@arminru arminru requested review from a team July 1, 2020 09:47
@Oberon00
Copy link
Member

Oberon00 commented Jul 1, 2020

Although it might be better to replace "ZPages" with "not exporter-based processor", cf. #663

@arminru
Copy link
Member Author

arminru commented Jul 1, 2020

@Oberon00 I think the diagram is intended to depict the current components shipped by default with the SDK as defined by the spec, which consists of only the simple and batching processor as of now.

@arminru arminru requested a review from a team July 1, 2020 14:24
@carlosalberto carlosalberto merged commit c8554d8 into open-telemetry:master Jul 1, 2020
codeboten pushed a commit to codeboten/opentelemetry-specification that referenced this pull request Jul 20, 2020
@arminru arminru deleted the remove-zpages branch September 17, 2020 12:45
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants