Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semantic conventions for more Kubernetes objects #732

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Add semantic conventions for more Kubernetes objects #732

merged 1 commit into from
Jul 25, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team July 23, 2020 20:19
tigrannajaryan
tigrannajaryan approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosalberto carlosalberto added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory labels Jul 24, 2020
@bogdandrutu bogdandrutu changed the title Add semantic conventions for all Kubernetes objects Add semantic conventions for more Kubernetes objects Jul 24, 2020
@carlosalberto carlosalberto self-requested a review July 24, 2020 16:00
@bogdandrutu
Add semantic conventions for all Kubernetes objects
24d9209 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
dmitryax
dmitryax reviewed Jul 24, 2020
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to cover kubernetes nodes here with attribute like k8s.node.name and k8s.node.uid?

@bogdandrutu bogdandrutu merged commit de3b65e into open-telemetry:master Jul 25, 2020
@bogdandrutu bogdandrutu deleted the k8s branch July 25, 2020 20:50
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@bogdandrutu
Add semantic conventions for all Kubernetes objects (open-telemetry#732)
aa7b8e4 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@dmitryax dmitryax dmitryax approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

@anuraaga anuraaga anuraaga approved these changes

Assignees
No one assigned
Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bogdandrutu @anuraaga @carlosalberto @tigrannajaryan @dmitryax