Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify that resources map to jaeger process tags #891

Merged
merged 4 commits into from
Sep 1, 2020

Conversation

mwear
Copy link
Member

@mwear mwear commented Aug 26, 2020

Fixes #848

Changes

This PR specifies resource mapping for Jaeger exporters. Currently different projects are handling the mapping of resources in one of two ways:

  • Merging resource attributes with span attributes (on a per span basis)
  • Exporting as process tags

This PR specifies that resources MUST be exported as process tags.

Related issues #848

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carlosalberto carlosalberto self-requested a review August 31, 2020 09:53
@bogdandrutu bogdandrutu merged commit 8431f39 into open-telemetry:master Sep 1, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* specify that resources map to jaeger process tags

* add changelog entry

* be less prescriptive on handling multiple resources

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define resource mapping for Jaeger export
6 participants