-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Span.Status per OTEP-134 #918
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b2657f1
Remove Span.Status per OTEP-134
iNikem 0b6c065
Update specification/trace/semantic_conventions/rpc.md
iNikem aea6201
Fix
iNikem 2c04831
Update CHANGELOG.md
iNikem 05cb1e1
Update specification/trace/semantic_conventions/rpc.md
iNikem 755370f
Marked changes in spec complience matrix
iNikem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,17 +26,10 @@ Table of Contents | |
* [IsRecording](#isrecording) | ||
* [Set Attributes](#set-attributes) | ||
* [Add Events](#add-events) | ||
* [Set Status](#set-status) | ||
* [UpdateName](#updatename) | ||
* [End](#end) | ||
* [Record Exception](#record-exception) | ||
* [Span lifetime](#span-lifetime) | ||
* [Status](#status) | ||
* [StatusCanonicalCode](#statuscanonicalcode) | ||
* [Status creation](#status-creation) | ||
* [GetCanonicalCode](#getcanonicalcode) | ||
* [GetDescription](#getdescription) | ||
* [GetIsOk](#getisok) | ||
* [SpanKind](#spankind) | ||
* [Concurrency](#concurrency) | ||
* [Included Propagators](#included-propagators) | ||
|
@@ -226,7 +219,6 @@ the entire operation and, optionally, one or more sub-spans for its sub-operatio | |
- [`Attributes`](../common/common.md#attributes) | ||
- A list of [`Link`s](#add-links) to other `Span`s | ||
- A list of timestamped [`Event`s](#add-events) | ||
- A [`Status`](#set-status). | ||
|
||
The _span name_ concisely identifies the work represented by the Span, | ||
for example, an RPC method name, a function name, | ||
|
@@ -371,8 +363,8 @@ Links SHOULD preserve the order in which they're set. | |
|
||
### Span operations | ||
|
||
With the exception of the function to retrieve the `Span`'s `SpanContext` and | ||
recording status, none of the below may be called after the `Span` is finished. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: This is wrong even in the current spec before removing status. |
||
With the exception of the function to retrieve the `Span`'s `SpanContext`, | ||
none of the below may be called after the `Span` is finished. | ||
|
||
#### Get Context | ||
|
||
|
@@ -385,8 +377,7 @@ The Span interface MUST provide: | |
#### IsRecording | ||
|
||
Returns true if this `Span` is recording information like events with the | ||
`AddEvent` operation, attributes using `SetAttributes`, status with `SetStatus`, | ||
etc. | ||
`AddEvent` operation, attributes using `SetAttributes`, etc. | ||
|
||
There should be no parameter. | ||
|
||
|
@@ -454,19 +445,6 @@ keys"](semantic_conventions/README.md) which have prescribed semantic meanings. | |
Note that [`RecordException`](#record-exception) is a specialized variant of | ||
`AddEvent` for recording exception events. | ||
|
||
#### Set Status | ||
|
||
Sets the [`Status`](#status) of the `Span`. If used, this will override the | ||
default `Span` status, which is `OK`. | ||
|
||
Only the value of the last call will be recorded, and implementations are free | ||
to ignore previous calls. | ||
|
||
The Span interface MUST provide: | ||
|
||
- An API to set the `Status` where the new status is the only argument. This | ||
SHOULD be called `SetStatus`. | ||
|
||
#### UpdateName | ||
|
||
Updates the `Span` name. Upon this update, any sampling behavior based on `Span` | ||
|
@@ -536,90 +514,6 @@ timestamps to the Span object: | |
Start and end time as well as Event's timestamps MUST be recorded at a time of a | ||
calling of corresponding API. | ||
|
||
## Status | ||
|
||
`Status` interface represents the status of a finished `Span`. It's composed of | ||
a canonical code in conjunction with an optional descriptive message. | ||
|
||
### StatusCanonicalCode | ||
|
||
`StatusCanonicalCode` represents the canonical set of status codes of a finished | ||
`Span`, following the [Standard GRPC | ||
codes](https://github.com/grpc/grpc/blob/master/doc/statuscodes.md): | ||
|
||
- `Ok` | ||
- The operation completed successfully. | ||
- `Cancelled` | ||
- The operation was cancelled (typically by the caller). | ||
- `Unknown` | ||
- An unknown error. | ||
- `InvalidArgument` | ||
- Client specified an invalid argument. Note that this differs from | ||
`FailedPrecondition`. `InvalidArgument` indicates arguments that are problematic | ||
regardless of the state of the system. | ||
- `DeadlineExceeded` | ||
- Deadline expired before operation could complete. For operations that change the | ||
state of the system, this error may be returned even if the operation has | ||
completed successfully. | ||
- `NotFound` | ||
- Some requested entity (e.g., file or directory) was not found. | ||
- `AlreadyExists` | ||
- Some entity that we attempted to create (e.g., file or directory) already exists. | ||
- `PermissionDenied` | ||
- The caller does not have permission to execute the specified operation. | ||
`PermissionDenied` must not be used if the caller cannot be identified (use | ||
`Unauthenticated1` instead for those errors). | ||
- `ResourceExhausted` | ||
- Some resource has been exhausted, perhaps a per-user quota, or perhaps the | ||
entire file system is out of space. | ||
- `FailedPrecondition` | ||
- Operation was rejected because the system is not in a state required for the | ||
operation's execution. | ||
- `Aborted` | ||
- The operation was aborted, typically due to a concurrency issue like sequencer | ||
check failures, transaction aborts, etc. | ||
- `OutOfRange` | ||
- Operation was attempted past the valid range. E.g., seeking or reading past end | ||
of file. Unlike `InvalidArgument`, this error indicates a problem that may be | ||
fixed if the system state changes. | ||
- `Unimplemented` | ||
- Operation is not implemented or not supported/enabled in this service. | ||
- `Internal` | ||
- Internal errors. Means some invariants expected by underlying system has been | ||
broken. | ||
- `Unavailable` | ||
- The service is currently unavailable. This is a most likely a transient | ||
condition and may be corrected by retrying with a backoff. | ||
- `DataLoss` | ||
- Unrecoverable data loss or corruption. | ||
- `Unauthenticated` | ||
- The request does not have valid authentication credentials for the operation. | ||
|
||
### Status creation | ||
|
||
API MUST provide a way to create a new `Status`. | ||
|
||
Required parameters | ||
|
||
- `StatusCanonicalCode` of this `Status`. | ||
|
||
Optional parameters | ||
|
||
- Description of this `Status`. | ||
|
||
### GetCanonicalCode | ||
|
||
Returns the `StatusCanonicalCode` of this `Status`. | ||
|
||
### GetDescription | ||
|
||
Returns the description of this `Status`. | ||
Languages should follow their usual conventions on whether to return `null` or an empty string here if no description was given. | ||
|
||
### GetIsOk | ||
|
||
Returns true if the canonical code of this `Status` is `Ok`, otherwise false. | ||
|
||
## SpanKind | ||
|
||
`SpanKind` describes the relationship between the Span, its parents, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could keep this and add something like
(REMOVED)
to keep track of its removal process (until all SIGs are done).