Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding known values for OTEL_PROPAGATORS #962

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

codeboten
Copy link
Contributor

Changes

Adds known propagator values to the environment variables specification.

@carlosalberto
Copy link
Contributor

carlosalberto commented Sep 17, 2020

Overall LGTM - however, I think we need to add a value to specify B3's formats (single and multiple). As the single part is the default, probably we should have something like:

  • b3 specifies single header format.
  • b3multi (or similar) specifies multiple format.

EDIT: The B3 case may disappear, depending on whether #961 is merged ;)

@carlosalberto
Copy link
Contributor

@open-telemetry/specs-approvers Please review this PR.

@arminru
Copy link
Member

arminru commented Sep 18, 2020

@carlosalberto Should we wait for #961 to settle then or go with just b3 for now?

@carlosalberto
Copy link
Contributor

@arminru As there seems to be initial agreement on having a single B3 Propagator, I'd suggest we go with b3 for now (if that changes, we can always add a b3single or b3multi very fast afterwards).

@carlosalberto carlosalberto merged commit ce51040 into open-telemetry:master Sep 21, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants