Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump collector version to 0.53.0 #1468

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 21, 2022

Update collector getting started with most recent version.


Preview: https://deploy-preview-1468--opentelemetry.netlify.app/docs/collector/getting-started/

@svrnm svrnm requested a review from a team June 21, 2022 14:59
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a way in hugo to define the version up at the top of the page and then splice it into each section in this page? Not a massive deal but I wonder if it's easy to set up. May not with the code blocks.

@svrnm
Copy link
Member Author

svrnm commented Jun 21, 2022

I wonder if there's a way in hugo to define the version up at the top of the page and then splice it into each section in this page? Not a massive deal but I wonder if it's easy to set up. May not with the code blocks.

that's actually a great idea, let me check, I think hugo has something build in here (I saw some {{% param title %}} at other pages)

@svrnm svrnm requested a review from cartermp June 21, 2022 15:19
@svrnm
Copy link
Member Author

svrnm commented Jun 21, 2022

Introduced a variable at the top of the page and use it through out for the version, seems to work well. Can we have it like that, thoughts? @cartermp @chalin @austinlparker ?

@cartermp
Copy link
Contributor

Nice, I like it a lot.

@chalin
Copy link
Contributor

chalin commented Jun 21, 2022

Introduced a variable at the top of the page and use it through out for the version, seems to work well. Can we have it like that, thoughts? @cartermp @chalin @austinlparker ?

Yep! Great step towards #1194.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chalin chalin merged commit 081bdca into open-telemetry:main Jun 21, 2022
@svrnm svrnm deleted the bump-collector-version branch May 11, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants