Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert each registry-entry from .md to .yml and move into data folder #2249

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 1, 2023

  • Closes Registry cleanup: make entry files pure data files #2247
  • Converts registry-entry .md files to .yml, since each entry file only had YAML front matter.
  • Moves the registry-entry files into the repo's data folder under a registry directory.
  • This change ensures that the individual registry entries no longer show up in the sitemap.xml file.
  • No content changes were made to the

If y'all agree with this change, I'll update the other registry-entry related assets in a followup PR.

Preview: https://deploy-preview-2249--opentelemetry.netlify.app/registry


If you hover over Search, you'll now see how many entries there are:

image

Other than that, the search form functions as it did before.

Regarding the sitemap.xml cleanup:

$ (cd public && git diff sitemap.xml) | head -20 
diff --git a/sitemap.xml b/sitemap.xml
index dc048eb83..abf04933e 100644
--- a/sitemap.xml
+++ b/sitemap.xml
@@ -510,1795 +510,205 @@
     <loc>https://opentelemetry.io/blog/2019/opentelemetry-governance-committee-explained/</loc>
     <lastmod>2022-09-15T20:56:31+02:00</lastmod>
   </url><url>
-    <loc>https://opentelemetry.io/registry/otel-dotnet/</loc>
-    <lastmod>2020-10-16T13:04:06-04:00</lastmod>
-  </url><url>
-    <loc>https://opentelemetry.io/registry/instrumentation-dotnet-runtime/</loc>
-    <lastmod>2022-08-16T12:49:13-07:00</lastmod>
-  </url><url>
-    <loc>https://opentelemetry.io/docs/reference/specification/schemas/file_format_v1.0.0/</loc>
-  </url><url>
-    <loc>https://opentelemetry.io/docs/reference/specification/schemas/file_format_v1.1.0/</loc>
-  </url><url>
-    <loc>https://opentelemetry.io/registry/instrumentation-ruby-action-pack/</loc>
-    <lastmod>2022-10-11T07:54:22-06:00</lastmod>

@chalin chalin requested a review from a team February 1, 2023 18:56
@chalin chalin merged commit e7ea299 into open-telemetry:main Feb 2, 2023
@chalin chalin deleted the chalin-registry-data-2023-02-01 branch February 2, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry cleanup: make entry files pure data files
2 participants