Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build custom collector: refer to latest vers of collector #2263

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 3, 2023

@chalin chalin requested review from a team and mx-psi and removed request for a team February 3, 2023 16:18
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, how is collectorVersion updated?

@chalin
Copy link
Contributor Author

chalin commented Feb 3, 2023

LGTM, how is collectorVersion updated?

Thanks for the review and approval @mx-psi. The version is updated via a script, which reminds me, I need to update the script. Thanks for the reminder!

@chalin chalin merged commit 243dd4e into open-telemetry:main Feb 3, 2023
@chalin chalin deleted the chalin-im-build-collector-2023-02-03 branch February 3, 2023 16:38
@chalin
Copy link
Contributor Author

chalin commented Feb 3, 2023

For the record, I'll track the update via:

@mx-psi
Copy link
Member

mx-psi commented Feb 6, 2023

Thanks for the details, that makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building a custom collector refers to old collector version
2 participants