Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: enable Prettier checking #2290

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 7, 2023

Note that this PR was seeded with a formatting issue in the README.md file. The build did fail (for details, see the comment below). If the build fails, then that will confirm that the changes in this PR are working. I'll then remove the README.md file change.

@chalin chalin added the CI/infra CI & infrastructure label Feb 7, 2023
@chalin chalin requested a review from a team February 7, 2023 16:14
README.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@chalin
Copy link
Contributor Author

chalin commented Feb 7, 2023

Hurrah, the build failed as expected (https://app.netlify.com/sites/opentelemetry/deploys/63e27aaf3687ae00080394da):

11:22:44 AM: [warn] README.md
11:22:44 AM: [warn] Code style issues found in the above file. Forgot to run Prettier?
11:22:44 AM: ERROR: "check:formatting" exited with 1.
11:22:44 AM: ​
11:22:44 AM:   "build.command" failed                                        
image

So I'll remove the seeded error.

@chalin
Copy link
Contributor Author

chalin commented Feb 7, 2023

Build is green. This is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: check file formatting, including markdown
3 participants